This repository was archived by the owner on May 4, 2024. It is now read-only.
Make TypeTag enum use less memory #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekun000
requested review from
dariorussi,
davidiw,
vgao1996 and
wrwg
as code owners
dariorussi
approved these changes
Oct 2, 2022
Member
dariorussi
left a comment
dariorussi
left a comment
There was a problem hiding this comment.
this is a good change, no question; bloating of enums is always a problem in Rust and the dereference here I believe is marginal. In fact this is likely to make things faster.
Failures look legit and this most likely needs to wait for 526 and so will change again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a single TypeTag consumes 96 bytes because of the inlined StructTag (88 bytes), it starts to bloat up with nested TypeTag::Vector(TypeTag).
This commit reduces the size from 96 to 16 bytes, it doesn't fully solve the problem but reduces the impact by 6x.