Skip to content
This repository was archived by the owner on May 4, 2024. It is now read-only.

[core-types] cherry-pick: Make TypeTag enum use less memory #677

Merged
wrwg merged 1 commit into from
Nov 17, 2022
Merged

[core-types] cherry-pick: Make TypeTag enum use less memory #677

wrwg merged 1 commit into from
Nov 17, 2022

Conversation

@vgao1996
Copy link
Member

@vgao1996 vgao1996 commented Nov 17, 2022

Cherry-picking #525

Currently a single TypeTag consumes 96 bytes because of the inlined StructTag (88 bytes), it starts to bloat up with nested TypeTag::Vector(TypeTag).
This commit reduces the size from 96 to 16 bytes, it doesn't fully solve the problem but reduces the impact by 6x.

wrwg
wrwg approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@wrwg wrwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I thought that one was already cherry-picked.

@wrwg wrwg merged commit eaeeb79 into move-language:main Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tnowacki tnowacki Awaiting requested review from tnowacki

@sblackshear sblackshear Awaiting requested review from sblackshear

@zekun000 zekun000 Awaiting requested review from zekun000

@dariorussi dariorussi Awaiting requested review from dariorussi

1 more reviewer

@wrwg wrwg wrwg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vgao1996 @wrwg @zekun000