Skip to content

correct explanation of padding parameters#627

Merged
v4hn merged 1 commit intomasterfrom
v4hn-patch-1
Apr 28, 2021
Merged

correct explanation of padding parameters#627
v4hn merged 1 commit intomasterfrom
v4hn-patch-1

Conversation

@v4hn
Copy link
Contributor

@v4hn v4hn commented Apr 16, 2021

@lianghongzhuo pointed out to me that the explanation was insufficient and when I looked it turned out to be wrong too...

@lianghongzhuo
Copy link

Actually, we find that padding scale was considered as min range in the ocotomap. if setting padding scale to 1, rviz will only show ocotomap far than 1 meter

@v4hn
Copy link
Contributor Author

v4hn commented Apr 16, 2021

I believe you're wrong. We will discuss/debug this offline.

@v4hn
Copy link
Contributor Author

v4hn commented Apr 16, 2021

Turns out, @lianghongzhuo found a bug in MoveIt's pointcloud_octomap_updater . I will file an issue in the main repository.

This is independent of this pull-request though.

Copy link

@lianghongzhuo lianghongzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has a more clear explanation than the previous one. And fix the wrong unit (cm -> m)

@v4hn v4hn merged commit da2b0e6 into master Apr 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the v4hn-patch-1 branch April 28, 2021 08:47
Abishalini pushed a commit to Abishalini/moveit_tutorials that referenced this pull request Apr 29, 2021
130s added a commit to 130s/moveit2_tutorials that referenced this pull request Jun 22, 2023
130s added a commit to 130s/moveit2_tutorials that referenced this pull request Jun 28, 2023
130s added a commit to 130s/moveit2_tutorials that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants