Closed
Conversation
Fix versions in package.xml, move to a ros2 branch
Contributor
|
I created a ros2 branch and directed this PR onto this new branch. |
Contributor
|
Is there already a ROS2-directed CI framework for Travis? |
Author
|
@rhaschke certain ROS 2 packages have enabled CI through Jenkins. E.g. see ros2/geometry2#90. Not sure what's required to get random_numbers there though. Requesting input from @tfoote and @clalancette. |
Contributor
|
@vmayoral The PR builds are enabled in the rosdistro just like ROS1: https://github.com/ros/rosdistro/blob/c6b6354dcc754d7e759afe888302676c986123c0/crystal/distribution.yaml#L562 |
Contributor
|
Sorry, I cannot help on ROS2 reviews. |
Merged
davetcoleman
approved these changes
Mar 26, 2019
Member
davetcoleman
left a comment
davetcoleman
left a comment
There was a problem hiding this comment.
Secondary approval to @mlautman
Contributor
|
Let's get travis working on this branch. I will be able to spend some more time on this tomorrow |
Contributor
|
Superseeded by #14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Following @clalancette guidelines, we're requesting a
ros2branch.Will re-submit the PR once it's been created.