Merged
Conversation
mlautman
force-pushed
the
ros2-travis
branch
2 times, most recently
from
16afd95 to
5045842
Compare
Member
|
Don't forget to assign a reviewer to your PRs |
| @@ -0,0 +1,66 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
Rather than having to maintain multiple clang format files, let's have it default to the moveit one. This is already implemented here:
https://github.com/ros-planning/moveit_ci/blob/ros2/check_clang_format.sh#L11
So this file should be removed.
Member
|
Looks good otherwise |
Closed
Closed
Fix versions in package.xml, move to a ros2 branch
rhaschke
approved these changes
Mar 28, 2019
Contributor
|
Rebased onto latest master and resolved conflicts. Waiting for Travis to succeed. |
the cmake linter is stupid, not accepting tabs...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the new movieit_ci changes. Includes changes from #12
This depends on the changes in moveit/moveit_ci#53
The latest commit can be dropped once that PR is merged