Skip to content

Update_Pronouns #484

Closed
hariv24 wants to merge 6 commits intomoveworks:mainfrom
hariv24:update-pronouns
Closed

Update_Pronouns #484
hariv24 wants to merge 6 commits intomoveworks:mainfrom
hariv24:update-pronouns

Conversation

@hariv24
Copy link
Copy Markdown
Contributor

@hariv24 hariv24 commented May 19, 2025

Update Pronouns SAP SUCESSFACTORS

@hariv24 hariv24 requested a review from ajaymerchia as a code owner May 19, 2025 14:12
@ghost
Copy link
Copy Markdown

ghost commented May 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

code/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Copy Markdown

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

In the installation steps, plugin installation documentation is not hyperlinked.

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

Information on required permissions is absent

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

I believe the wording is also different than the sample
Here's one for your reference
https://developer.moveworks.com/marketplace/plugin?id=coupa-approve-reject-requisition&hist=home%2Cpkg.coupa#how-to-implement

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

Remove connector from the Prerequisites section since it's already covered under Installation Steps

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

Authorization: Bearer not there for API #1: Fetch User Information

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

Remove

Slots:

UserId.
Pronoun ID.

From the last API

@github-actions
Copy link
Copy Markdown

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

It's SAP SuccessFactors (with S and F capitalized). Please change that
Otherwise, looks good to me

@github-actions
Copy link
Copy Markdown

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

Approved

@indrapaul24 indrapaul24 added the arbaan Pull requests from Arbaan label May 30, 2025
@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@hariv24 hariv24 closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arbaan Pull requests from Arbaan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants