Skip to content

Lookup Holiday Schedule #485

Merged
indrapaul24 merged 4 commits intomoveworks:mainfrom
hariv24:Lookup-Holiday-Schedule
May 30, 2025
Merged

Lookup Holiday Schedule #485
indrapaul24 merged 4 commits intomoveworks:mainfrom
hariv24:Lookup-Holiday-Schedule

Conversation

@hariv24
Copy link
Copy Markdown
Contributor

@hariv24 hariv24 commented May 19, 2025

No description provided.

@hariv24 hariv24 requested a review from ajaymerchia as a code owner May 19, 2025 17:52
@ghost
Copy link
Copy Markdown

ghost commented May 19, 2025 •
edited by ghost
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ code/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2025

Changes to plugins/workday-lookup-holiday-schedule/README.md can be viewed at https://developer.moveworks.com/creator-studio/resources/plugin?id=workday-lookup-holiday-schedule&commit_id=2c9a9d772c4c6558993e224f35ebec348a625f91;

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

sbhadwal-moveworks commented May 22, 2025

Please refer to comments on #481 and #484 and make the relevant changes

@hariv24
Update README.md: Remove outdated Workday Connector guide link and ad…
9fcc8db 
…d required permissions for Lookup Holiday Schedule plugin
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2025

Changes to plugins/workday-lookup-holiday-schedule/README.md can be viewed at https://developer.moveworks.com/creator-studio/resources/plugin?id=workday-lookup-holiday-schedule&commit_id=9fcc8dbdf99549b921f4e7767f30e43b60726606;

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

sbhadwal-moveworks commented May 23, 2025

Should be Look Up instead of Lookup

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

sbhadwal-moveworks commented May 23, 2025

Other than that looks good to me

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2025

Changes to plugins/workday-lookup-holiday-schedule/README.md can be viewed at https://developer.moveworks.com/creator-studio/resources/plugin?id=workday-lookup-holiday-schedule&commit_id=965bc5d6762669a9586e7fddabfa15edf57d5ee9;

@sbhadwal-moveworks
Copy link
Copy Markdown
Contributor

sbhadwal-moveworks commented May 29, 2025

Approved

@indrapaul24 indrapaul24 added the arbaan Pull requests from Arbaan label May 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 30, 2025

Changes to plugins/workday-lookup-holiday-schedule/README.md can be viewed at https://developer.moveworks.com/creator-studio/resources/plugin?id=workday-lookup-holiday-schedule&commit_id=79d71a1f007b8dfc41373b514f9f2622d5773213;

@indrapaul24 indrapaul24 merged commit 34756dd into moveworks:main May 30, 2025
3 checks passed
Sudheer2137 pushed a commit that referenced this pull request Jul 22, 2025
@hariv24 @indrapaul24
Lookup Holiday Schedule (#485)
e0a6fb2 
* Lookup Holiday Schedule plugin

* Update README.md: Remove outdated Workday Connector guide link and add required permissions for Lookup Holiday Schedule plugin

* Fix spelling in README.md: Update "Lookup" to "Look Up" for consistency

---------

Co-authored-by: Indrashis Paul <indrashis.paul@moveworks.ai>
tdavison-moveworks pushed a commit that referenced this pull request Jul 25, 2025
@hariv24 @indrapaul24
Lookup Holiday Schedule (#485)
e7ab672 
* Lookup Holiday Schedule plugin

* Update README.md: Remove outdated Workday Connector guide link and add required permissions for Lookup Holiday Schedule plugin

* Fix spelling in README.md: Update "Lookup" to "Look Up" for consistency

---------

Co-authored-by: Indrashis Paul <indrashis.paul@moveworks.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indrapaul24 indrapaul24 indrapaul24 approved these changes

@ajaymerchia ajaymerchia Awaiting requested review from ajaymerchia ajaymerchia is a code owner

Assignees

No one assigned

Labels

arbaan Pull requests from Arbaan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hariv24 @sbhadwal-moveworks @indrapaul24