Refactor FXIOS-14282 [Trending Searches] use new rust methods specifi… #30936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
requested review from
Cramsden and
issammani
and removed request for
Cramsden
💪 Quality guardian3 tests files modified. You're a champion of test coverage! 🚀 🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Client.app: Coverage: 37.05
libStorage.a: Coverage: 54.93
Generated by 🚫 Danger Swift against 7353b81 |
Contributor
|
🚀 PR merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR replaces two methods that we were using previously to display and delete recent searches,
getMostRecentHistoryMetadataanddeleteHistoryMetadataOlderThanrespectively. We were using these because these were the best existing methods to implement the feature.However, we recently added some new rust methods that are specific to showing metadata related to search queries and not the entire history metadata. The two new methods are:
metadataDeleteSearchTerms: Addmetadata_delete_search_termsmethod to delete search terms in history metadata mozilla/application-services#7101getMostRecentSearchEntriesInHistoryMetadata: Addget_most_recent_search_entries_in_history_metadatamethod to fetch search entries mozilla/application-services#7104🎥 Demos
Simulator.Screen.Recording.-.iPhone.16e.-.2025-11-25.at.18.15.29.mov
Note: To test, ensure that you have the features on in debug menu and you navigate to the recent searches section after tapping on the address bar from a webpage.
📝 Checklist