Skip to content

Conversation

@cyndichin
Copy link
Contributor

@cyndichin cyndichin commented Nov 25, 2025

Pull Request checklist

This patch adds a new method get_most_recent_search_entries_in_history_metadata that fetches the most recent entries in the moz_places_metadata table that does not have a null search term. This is to support a new feature in which we want to fetch only the recent search entries instead of fetching the entire history metadata entries.

If we ever decided to add entries with null search terms, then using the convenience method get_most_recent_history_metadata will not suffice and fetches the top 5 entries instead of the top 5 with search terms.

Overall, the new feature we want to support is to show the users recent search terms stored. This PR was also created to support the same feature.

cc: @issammani

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@cyndichin cyndichin changed the title Add method to fetch search entries Add get_most_recent_search_entries_in_history_metadata method to fetch search entries Nov 25, 2025
@cyndichin cyndichin force-pushed the feat/add-get-most-recent-search-entries-in-history-metadata branch from c800583 to 25f3409 Compare November 25, 2025 13:37
### Logins
- fix `count_by_origin` and `count_by_form_action_origin` with punicode origins

### Places
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this may conflict with #7101, so need to wait for that PR to merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved here: 60f5b82

@cyndichin cyndichin force-pushed the feat/add-get-most-recent-search-entries-in-history-metadata branch 2 times, most recently from 98d5316 to d21c547 Compare November 25, 2025 14:24
@cyndichin cyndichin force-pushed the feat/add-get-most-recent-search-entries-in-history-metadata branch from d21c547 to a3455b9 Compare November 25, 2025 14:25
@cyndichin cyndichin marked this pull request as ready for review November 25, 2025 15:02
@cyndichin
Copy link
Contributor Author

@mhammond this PR is now ready to review! Thank you!

@mhammond mhammond enabled auto-merge November 25, 2025 15:21
@mhammond mhammond added this pull request to the merge queue Nov 25, 2025
Merged via the queue into mozilla:main with commit 4bbc24e Nov 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants