Replace mpd001 trust domain with mozillavpn#512
Merged
bhearsum merged 1 commit intomozilla-releng:masterfrom Aug 24, 2021
Merged
Replace mpd001 trust domain with mozillavpn#512bhearsum merged 1 commit intomozilla-releng:masterfrom
bhearsum merged 1 commit intomozilla-releng:masterfrom
Conversation
Contributor
|
Timeout bustage appears to be #509 ; merging master in or rebasing the PR should resolve. |
bhearsum
force-pushed
the
mozillavpn
branch
4 times, most recently
from
6325215 to
9a69347
Compare
escapewindow
approved these changes
Aug 24, 2021
Contributor
escapewindow
left a comment
escapewindow
left a comment
There was a problem hiding this comment.
Thanks, looks good!
| "thunderbird": "COMM", | ||
| "mobile": "MOBILE", | ||
| "mpd001": "MPD001", | ||
| "mozillavpn": "MOZILLAVPN", |
Contributor
There was a problem hiding this comment.
This means we're going to look for MOZILLAVPN_HEAD_REV etc, which will be relevant in your .tc.yml
| @pytest.mark.asyncio | ||
| @pytest.yield_fixture(scope="function") | ||
| async def mpd_private_rw_context(event_loop): | ||
| async def vpn_private_rw_context(event_loop): |
Contributor
There was a problem hiding this comment.
This is specifically for testing private repos, but I think it may be useful for later private repo usage. We can keep it, esp since your test data file below starts with git@github rather than https://github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICT there's no reason to continue supporting the
mpd001trust domain.