Skip to content

Use Github Checks for taskcluster reporting#513

Merged
escapewindow merged 3 commits intomozilla-releng:masterfrom
bhearsum:checks
Apr 19, 2022
Merged

Use Github Checks for taskcluster reporting#513
escapewindow merged 3 commits intomozilla-releng:masterfrom
bhearsum:checks

Conversation

@bhearsum
Copy link
Copy Markdown
Contributor

No description provided.

@escapewindow
Copy link
Copy Markdown
Contributor

Timeout bustage appears to be #509 ; merging master in or rebasing the PR should resolve.

@bhearsum
Copy link
Copy Markdown
Contributor Author

https://phabricator.services.mozilla.com/D123440 for the necessary ci-config change for this

Copy link
Copy Markdown
Contributor

@escapewindow escapewindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I like that the checks tab is populated now.
The ci-config patch appears to be merged.

Do you know why we're getting this?
Screen Shot 2021-08-24 at 9 28 17 AM

Setting change needed? Are we missing a decision task name here?

@bhearsum
Copy link
Copy Markdown
Contributor Author

Looks good, and I like that the checks tab is populated now.
The ci-config patch appears to be merged.

Do you know why we're getting this?
Screen Shot 2021-08-24 at 9 28 17 AM

Setting change needed? Are we missing a decision task name here?

That's due to branch protection settings:
image

If we want to depend on a single required check, we'll need to add a diamond closing one (eg: pr-complete). Alternatively, we can add all of the tasks as required checks (or not worry about it at all).

@escapewindow
Copy link
Copy Markdown
Contributor

It looks like in #512 we had that. I'm guessing moving to checks-v1 removes that?
Screen Shot 2021-08-24 at 12 47 00 PM

@escapewindow
Copy link
Copy Markdown
Contributor

I think the real answer here is "we should port the scriptworker repo to taskgraph". =\

@bhearsum
Copy link
Copy Markdown
Contributor Author

It looks like in #512 we had that. I'm guessing moving to checks-v1 removes that?
Screen Shot 2021-08-24 at 12 47 00 PM

Yeah, checks replaces the overall "this task group passed or failed" with per-task status'. We can punt on this for now if you want, it's not a big deal.

@escapewindow
Copy link
Copy Markdown
Contributor

Taskgraph is #534.

@escapewindow escapewindow merged commit fea5bea into mozilla-releng:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants