Skip to content

Conversation

@janbrasna
Copy link
Contributor

This adds some ruff exclusions from default lint rules that landed with updates, to unblock CI.

(Marked up FIXME for now, most are uncontroversial to tackle if there's appetite.)

This also updates actions/* versions to avoid any deprecations, warnings or noisy annotations while having a little safer defaults as a byproduct; also adding explicit non-default Python to the envlist job to avoid some runner defaults' woes installing system packages etc. (fixing some yaml whitespace while at it…) and adds wheel caching for pip deps.

Backfills the matrix for compatible combinations to not skip any viable versions.

Updates some metadata, mostly aligning python_requires with claimed support.

Adding current Python and Django to the envlist, removing some EOLed versions.

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@leplatrem leplatrem merged commit 3221444 into mozilla-services:main Aug 11, 2025
61 checks passed
@janbrasna janbrasna deleted the upd/ci-lts-eol branch August 11, 2025 09:27
@janbrasna
Copy link
Contributor Author

Funnily enough, this was happily passing few months ago 😓

I'll keep spelunking why it now fails on main; if that pulls some non-stable versions or something?

@janbrasna
Copy link
Contributor Author

janbrasna commented Aug 11, 2025

And of course, pip tox somehow resolves to breaking pre-release versions of httpx it seems 🙈

We can pin ourselves to resolve FastAPI side of things: janbrasna@0152d83 — but the Sanic has to be fixed upstream: https://github.com/search?q=repo:sanic-org/sanic-testing+httpx

@janbrasna
Copy link
Contributor Author

OK found a sanic-testing version that has an upper constraint for httpx too that won't crash on ValueError — gonna update a couple more things with it, that no longer work on Python 3.8 — and submit another bump, pinning few things and dropping some EOL versions.

@leplatrem
Copy link
Contributor

leplatrem commented Nov 4, 2025 via email

@janbrasna
Copy link
Contributor Author

Sure thing! How would I look if a CI fix didn't turn green after landing?;D — I'll hunt down the things that shift beyond us over time, like another ruff rule that I might need to ignore to pass again;)

That said, fakeredis doesn't probably correctly specify its lower compatibility so we're getting a version that doesn't work with Python 3.8 ~ I could also try to find a version that broke the compatibility and pin it, but I'm more inclined to just leave EOL Python 3.8 behind, and move up to 3.9 as the lowest supported.

@janbrasna
Copy link
Contributor Author

Following up in #122 — green for now;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants