fix(exit):[Workday/Everfi]Added sys.exit() calls#250
Merged
Conversation
scholtzan
approved these changes
Jul 30, 2024
jaredsnyder
pushed a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com>
jaredsnyder
added a commit
that referenced
this pull request
Aug 14, 2024
* refactored base_forecast and prophet_forecast to enable easier testing * Apply suggestions from code review change signatures of `fit` and `predict` to take arguments that default to attributes Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * add test for fit * revert signatures * made timezone-aware stamps naive * finished base_forecast tests * added tests for prophet class * linting * fixed divide by zero * linting again * adding tests to funnel_forecast * added tests for funnel_forecast * feat(workday):remove unwanted fields (#249) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix(exit):Added sys.exit() call (#250) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix issue with call to _get_crossvalidation_metric * fixed type check * added string case to aggregate_to_period and added tests * revert file * typo * revert bugfix in _add_regressors * update tests to reflect reversion --------- Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> Co-authored-by: JCMOSCON1976 <167822375+JCMOSCON1976@users.noreply.github.com> Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> Co-authored-by: m-d-bowerman <mbowerman@mozilla.com>
jaredsnyder
added a commit
that referenced
this pull request
Aug 14, 2024
* refactored base_forecast and prophet_forecast to enable easier testing * Apply suggestions from code review change signatures of `fit` and `predict` to take arguments that default to attributes Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * add test for fit * revert signatures * made timezone-aware stamps naive * finished base_forecast tests * added tests for prophet class * linting * fixed divide by zero * linting again * adding tests to funnel_forecast * added tests for funnel_forecast * feat(workday):remove unwanted fields (#249) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix(exit):Added sys.exit() call (#250) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix issue with call to _get_crossvalidation_metric * fixed type check * added string case to aggregate_to_period and added tests * revert file * added more tests to prophet_forecast * Update jobs/kpi-forecasting/kpi_forecasting/models/base_forecast.py Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * Brad easy fixes * remove magic year * feat(code):increasing the max_limit from 10 to 40. (#259) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * typo * revert bugfix in _add_regressors * update tests to reflect reversion --------- Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> Co-authored-by: JCMOSCON1976 <167822375+JCMOSCON1976@users.noreply.github.com> Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> Co-authored-by: m-d-bowerman <mbowerman@mozilla.com>
jaredsnyder
added a commit
that referenced
this pull request
Aug 16, 2024
* refactored base_forecast and prophet_forecast to enable easier testing * Apply suggestions from code review change signatures of `fit` and `predict` to take arguments that default to attributes Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * add test for fit * revert signatures * made timezone-aware stamps naive * finished base_forecast tests * added tests for prophet class * linting * fixed divide by zero * linting again * adding tests to funnel_forecast * added tests for funnel_forecast * feat(workday):remove unwanted fields (#249) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix(exit):Added sys.exit() call (#250) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix issue with call to _get_crossvalidation_metric * fixed type check * added string case to aggregate_to_period and added tests * revert file * added more tests to prophet_forecast * removed DotMap * modified README to make it match better between FunnelForecast and ProphetForecast * Update jobs/kpi-forecasting/kpi_forecasting/models/base_forecast.py Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * Brad easy fixes * remove magic year * removed DotMap * modified README to make it match better between FunnelForecast and ProphetForecast * added test for more complex segments * renamed use_holidays to use_all_us_holidays * typo * added detail to prophet parameter descriptions * updated setting of default start date and added tests * remove print * moved filter and updated tests to relfect this --------- Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> Co-authored-by: JCMOSCON1976 <167822375+JCMOSCON1976@users.noreply.github.com> Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> Co-authored-by: m-d-bowerman <mbowerman@mozilla.com>
jaredsnyder
added a commit
that referenced
this pull request
Oct 8, 2024
* refactored base_forecast and prophet_forecast to enable easier testing * Apply suggestions from code review change signatures of `fit` and `predict` to take arguments that default to attributes Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * add test for fit * revert signatures * made timezone-aware stamps naive * finished base_forecast tests * added tests for prophet class * linting * fixed divide by zero * linting again * adding tests to funnel_forecast * added tests for funnel_forecast * feat(workday):remove unwanted fields (#249) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix(exit):Added sys.exit() call (#250) Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> * fix issue with call to _get_crossvalidation_metric * fixed type check * added string case to aggregate_to_period and added tests * revert file * added more tests to prophet_forecast * removed DotMap * modified README to make it match better between FunnelForecast and ProphetForecast * Update jobs/kpi-forecasting/kpi_forecasting/models/base_forecast.py Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * Brad easy fixes * remove magic year * removed DotMap * modified README to make it match better between FunnelForecast and ProphetForecast * added test for more complex segments * renamed use_holidays to use_all_us_holidays * typo * added detail to prophet parameter descriptions * updated setting of default start date and added tests * remove print * moved filter and updated tests to relfect this * renamed use_holiday and moved functions around * fix merge conflict * move updated _add_regressors to prophet_forecast * partially completed moving methods out of FunnelForecast * finished updating classes * tests working * update docs and linting * more linting * towards thee I roll thou all-destroying but unconquering whale to the last i grapple with thee, from hells heart I stab at thee, for hates sake I spit my last breath at thee * fixes to make it run all the way through * linting * fixes so funnel forecast dates work as expected * fixed size of search tables * validation fixes cont * fix regressor bug * move set_seed around and explicitly set self.growth after autotuning * better readme * Remove 1 from priors list * kpi_forecasting * Brad config updates * Brad config fixes * missed one * Apply suggestions from code review Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * Update jobs/kpi-forecasting/kpi_forecasting/models/prophet_forecast.py Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * Update jobs/kpi-forecasting/kpi_forecasting.py Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> * change name in list comprehension * updated README --------- Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com> Co-authored-by: JCMOSCON1976 <167822375+JCMOSCON1976@users.noreply.github.com> Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com> Co-authored-by: m-d-bowerman <mbowerman@mozilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sys.exit() calls to run function.
Jira ticketASP-5042
EpicASP-4744