added more tests to prophet_forecast#264
Merged
Merged
Conversation
change signatures of `fit` and `predict` to take arguments that default to attributes Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com>
Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com>
Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com>
bochocki
approved these changes
Aug 9, 2024
Contributor
bochocki
left a comment
bochocki
left a comment
There was a problem hiding this comment.
This looks good! Nice work adding so many tests; hopefully this makes the updates more robust. I made a few small comments, not blocking, but I think some light touch-ups could make the code more readable.
Once this is merged, let's make sure to re-trigger the KPI Forecast Airflow task to make sure that it completes, and then verify that the dashboards aren't broken. Feel free to ping me for that step and I can validate Airflow + dashboards if you like.
Co-authored-by: Brad Ochocki Szasz <bochocki@mozilla.com>
Co-authored-by: Julio Cezar Moscon <jcmoscon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the
predict,_predict,_fit,fit, and summarize methods forProphetForecastto make it easier to refactor this codeChecklist for reviewer:
referenced, the pull request should include the bug number in the title)
.circleci/config.yml) will cause environment variables (particularlycredentials) to be exposed in test logs
telemetry-airflow
responsibly.