Skip to content

bug 2020056: Fix Glean log pipe corruption on Windows#3413

Merged
badboy merged 1 commit intomozilla:mainfrom
ahochheiden:fix-windows-pipe-handle
Mar 3, 2026
Merged

bug 2020056: Fix Glean log pipe corruption on Windows#3413
badboy merged 1 commit intomozilla:mainfrom
ahochheiden:fix-windows-pipe-handle

Conversation

@ahochheiden
Copy link
Copy Markdown
Member

@ahochheiden ahochheiden commented Mar 3, 2026

D283734 moved telemetry initialization to a separate thread on mach startup and uncovered this. On Windows, sometimes the logging shows up character by character on the MSYS2 terminal like so:

      0 [waitproc] bash 2253 proc_waiter: unknown value 123 on proc pipe
    114 [waitproc] bash 2253 proc_waiter: unknown value 34 on proc pipe
    199 [waitproc] bash 2253 proc_waiter: unknown value 108 on proc pipe
    256 [waitproc] bash 2253 proc_waiter: unknown value 101 on proc pipe
<sic>

It's not 100% reproducible, since the handle value the file descriptor mapped to isn't always one that produces visible output, but after applying this fix the symptom has yet to reappear for me locally.

@ahochheiden ahochheiden requested a review from a team as a code owner March 3, 2026 00:10
@ahochheiden ahochheiden requested review from chutten and removed request for a team March 3, 2026 00:10
@badboy badboy merged commit 211d9e5 into mozilla:main Mar 3, 2026
27 of 29 checks passed
@ahochheiden ahochheiden deleted the fix-windows-pipe-handle branch March 3, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants