Skip to content

bug 2020056: Fix Glean log pipe corruption on Windows #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badboy merged 1 commit into from
Mar 3, 2026
Merged

bug 2020056: Fix Glean log pipe corruption on Windows #3413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion glean-core/python/glean/_ffi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import json
import logging
import os
import sys
import threading


Expand All @@ -26,7 +27,16 @@ def setup_logging():
Must be called after the Glean core has been dlopen'd.
"""
r, w = os.pipe()
glean_enable_logging_to_fd(w)

if sys.platform == "win32":
# On Windows, os.pipe() returns C runtime file descriptors, but the
# Rust FdLogger expects a native Windows HANDLE (via FromRawHandle).
# Convert to a proper HANDLE with msvcrt.get_osfhandle().
import msvcrt

glean_enable_logging_to_fd(msvcrt.get_osfhandle(w))
else:
glean_enable_logging_to_fd(w)

reader = os.fdopen(r, encoding="utf-8")

Expand Down