Accessibility: Add localized aria-label to Download button in viewer … #20534
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| <!doctype html> | |||
| <!doctype html> | |||
Contributor
There was a problem hiding this comment.
This should be unrelated to the change at hand and should be reverted to keep the patch as small as possible (this is probably a UTF byte order mark added by an editor).
| type="button" | ||
| tabindex="0" | ||
| data-l10n-id="pdfjs-save-button" | ||
| data-l10n-attrs="title aria-label" |
Contributor
There was a problem hiding this comment.
It's not clear to me why the Download button is treated differently now compared to e.g. the Print button above. If we do this, shouldn't we do this consistently for all buttons instead?
@calixteman Are you aware of any accessibility rules from the UI/UX team around this, since we recently changed the HTML to accomodate for that better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a localized
aria-labelto the Download button in the viewer toolbar to improve accessibility for screenreader users.
Details
Previously, only the
titleattribute was localized, so the button did not expose an accessible name. By addingdata-l10n-attrs="title aria-label", bothtitleandaria-labelare now populated by the localization system,consistent with other toolbar buttons.
Result
Screen readers can now correctly announce the purpose of the Download button.
Fixes: #20473