Accessibility: Add localized aria-label to Download button in viewer … #20534
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <!doctype html> | ||
| <!-- | ||
| Copyright 2012 Mozilla Foundation | ||
|
|
||
|
|
@@ -339,11 +339,18 @@ | |
| <!-- findbar --> | ||
| </div> | ||
| <div class="toolbarHorizontalGroup hiddenSmallView"> | ||
| <button | ||
| class="toolbarButton" | ||
| type="button" | ||
| id="previous" | ||
| tabindex="0" | ||
| data-l10n-id="pdfjs-previous-button" | ||
| data-l10n-attrs="title aria-label" | ||
| > | ||
| <span data-l10n-id="pdfjs-previous-button-label"></span> | ||
| </button> | ||
| <div class="splitToolbarButtonSeparator"></div> | ||
| <button class="toolbarButton" type="button" id="next" tabindex="0" data-l10n-attrs="title aria-label"> | ||
| <span data-l10n-id="pdfjs-next-button-label"></span> | ||
| </button> | ||
| </div> | ||
|
|
@@ -365,11 +372,25 @@ | |
| </div> | ||
| <div id="toolbarViewerMiddle" class="toolbarHorizontalGroup"> | ||
| <div class="toolbarHorizontalGroup"> | ||
| <button | ||
| id="zoomOutButton" | ||
| class="toolbarButton" | ||
| type="button" | ||
| tabindex="0" | ||
| data-l10n-id="pdfjs-zoom-out-button" | ||
| data-l10n-attrs="title aria-label" | ||
| > | ||
| <span data-l10n-id="pdfjs-zoom-out-button-label"></span> | ||
| </button> | ||
| <div class="splitToolbarButtonSeparator"></div> | ||
| <button | ||
| id="zoomInButton" | ||
| class="toolbarButton" | ||
| type="button" | ||
| tabindex="0" | ||
| data-l10n-id="pdfjs-zoom-in-button" | ||
| data-l10n-attrs="title aria-label" | ||
| > | ||
| <span data-l10n-id="pdfjs-zoom-in-button-label"></span> | ||
| </button> | ||
| </div> | ||
|
|
@@ -607,11 +628,25 @@ | |
| <div id="editorModeSeparator" class="verticalToolbarSeparator"></div> | ||
|
|
||
| <div class="toolbarHorizontalGroup hiddenMediumView"> | ||
| <button | ||
| id="printButton" | ||
| class="toolbarButton" | ||
| type="button" | ||
| tabindex="0" | ||
| data-l10n-id="pdfjs-print-button" | ||
| data-l10n-attrs="title aria-label" | ||
| > | ||
| <span data-l10n-id="pdfjs-print-button-label"></span> | ||
| </button> | ||
|
|
||
| <button | ||
| id="downloadButton" | ||
| class="toolbarButton" | ||
| type="button" | ||
| tabindex="0" | ||
| data-l10n-id="pdfjs-save-button" | ||
| data-l10n-attrs="title aria-label" | ||
|
Contributor
There was a problem hiding this comment. It's not clear to me why the Download button is treated differently now compared to e.g. the Print button above. If we do this, shouldn't we do this consistently for all buttons instead? @calixteman Are you aware of any accessibility rules from the UI/UX team around this, since we recently changed the HTML to accomodate for that better?
Author
There was a problem hiding this comment. Thanks for the review! |
||
| > | ||
| <span data-l10n-id="pdfjs-save-button-label"></span> | ||
| </button> | ||
| </div> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be unrelated to the change at hand and should be reverted to keep the patch as small as possible (this is probably a UTF byte order mark added by an editor).