Conversation
emtwo
reviewed
Mar 25, 2019
| 'id': self.id, | ||
| 'object_id': self.object_id, | ||
| 'object_type': self.object_type, | ||
| 'change_type': self.change_type, |
There was a problem hiding this comment.
self.change_type doesn't exist and I think it causes issues in tests/handlers/test_queries.py
| class QueryVersionListResource(BaseResource): | ||
| @require_permission('view_query') | ||
| def get(self, query_id): | ||
| results = models.Change.filter( |
There was a problem hiding this comment.
This also seems to cause an issue in tests/handlers/test_queries.py. Wondering if the intention was models.Change.query.filter(...)
|
Pushed commits for:
|
emtwo
force-pushed
the
m20-rebase
branch
2 times, most recently
from
73c007a to
9308c88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m20 milestone rebase
This is the m20 milestone rebase which contains
all of Redash v7 and the commits from m19 below.
Better diff view: getredash/redash@master...mozilla:m20-rebase
TO DO
@ashort: Port query result aggregation to React
cab71d7 (Port of Angular to React)
5105abf (needs to merge with above)
83e0b3a (bugfix)
@emtwo: Migrate schedule_until to m20: Closes #427: Migrate schedule_until into new json schedule field. #591
@emtwo Apply schema drawer PRs
@washort Apply other PRs from upstream?
Code from Show queue position while waiting for query to execute getredash/redash#3583 incorporated for Show number of queries in queue while waiting for execution #786
@emtwo Review Remote groups redash-stmo#29
@jezdez release new redash-stmo version
Applied commits
a33e479
18695a9
1fc3098
57f11a7
a740615
6a0c867
17290cb
51be429
c27e225
1af1f42
340ac9f
b3abab9
d3eb2ad
9614858
68fa92e
a169e20
da09b7f
614ca83
af0ce47
0bcab1e
6f4bfdb
0f2f40e
7233ebb
e94d1f8
7a9c171
86f5c2f
Redundant commits not applied
68867f7 (merged with circleci commit)
87a7fb6 (considered anti-pattern)
d440b80 (feature to be ported to fork)
66501c1 (merged with column type PR)
Removed commits because of upstream fixes
0bd626d (node was upgraded to v10)
6fd67ed (needs follow-up see TODO)
e6d88ad (feature ported)
3b46720 (fixed upstream)
Removed commits after porting to redash-stmo
86f5c2f (mozilla/redash-stmo@63873a0)(was reverted in mozilla/redash-stmo@f3bc55f)23d6f7a (mozilla/redash-stmo#29)