Skip to content

Closes #427: Migrate schedule_until into new json schedule field.#591

Closed
emtwo wants to merge 32 commits intomasterfrom
emtwo/schedule_migration
Closed

Closes #427: Migrate schedule_until into new json schedule field.#591
emtwo wants to merge 32 commits intomasterfrom
emtwo/schedule_migration

Conversation

@emtwo
Copy link
Copy Markdown

@emtwo emtwo commented Oct 10, 2018

This migration should be applied after this PR lands upstream: getredash#2426 and is merged into our fork.

Allen Short and others added 27 commits December 17, 2018 13:20
- Use new master / rc release release strategy (#440)
- Migrate Circle CI 2.0 (#488, #502)
I tried to make
`JSON.stringify(this.visualization.options.columnMapping)` a variable
to avoid repeating it, but if I make it a `let` the linter throws an
error and if I make it a `const` then it doesn’t change with the UI and
the logic doesn’t work. :(

updated based on PR comments
In the long run we'll be able to install additional dependencies by
having an own Dockerfile to build images based on the Redash image
but that installs additional Python dependencies. But until we have
a fork with lots of changes ourselves we need to do it this way.

Redash-stmo contains the ability to hook up our own Dockerflow
library.

Refs #13
Refs #37
Extend the Remote User Auth backend with the ability to pass remote user groups via a configurable request header similar to the REMOTE_USER header.

Refs #37.

If enabled the feature allows checks the header value against a configured list of group names, including the ability to use UNIX shell-style wildcards.
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
jezdez and others added 3 commits December 17, 2018 13:20
Refs #537, #553.

Co-authored-by: Marina Samuel <msamuel@mozilla.com>
Co-authored-by: Allen Short <ashort@mozilla.com>
@jezdez
Copy link
Copy Markdown

jezdez commented Jan 16, 2019

@emtwo Would you mind rebasing this, since that's the next step to close #427 after getredash#2426 got merged?

@emtwo emtwo force-pushed the emtwo/schedule_migration branch from 1b30056 to 0f46b14 Compare January 23, 2019 17:17
@emtwo
Copy link
Copy Markdown
Author

emtwo commented Jan 23, 2019

I've rebased this PR with 2 notes to make:

  • This is now based on the last upstream migration which returned the ability for the schedule field to be null: getredash@e8120c5#diff-ae8945bd01a33cb1ff4e201d68685558
  • I've removed references to schedule_until from models.py and serializers.py in this PR as well, but these may not be necessary depending on if it takes place when we pull in the latest upstream code.

@jezdez jezdez force-pushed the master branch 2 times, most recently from d575ecf to 6f4bfdb Compare January 25, 2019 09:47
@jezdez
Copy link
Copy Markdown

jezdez commented Feb 25, 2019

@emtwo I'm sorry but could you please do another rebase for this?

@jezdez jezdez added this to the 20 milestone Feb 25, 2019
@jezdez jezdez mentioned this pull request Mar 25, 2019
6 tasks
@jezdez
Copy link
Copy Markdown

jezdez commented Apr 3, 2019

This was ported into the master branch in 0deaf2f (via #922).

@jezdez jezdez closed this Apr 3, 2019
@jezdez jezdez removed the blocked label Apr 3, 2019
@jezdez jezdez deleted the emtwo/schedule_migration branch April 3, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants