Remove "amdefine" and add define during build#202
Closed
zertosh wants to merge 1 commit intomozilla:masterfrom
zertosh:remove-amdefine
Closed
Remove "amdefine" and add define during build#202zertosh wants to merge 1 commit intomozilla:masterfrom zertosh:remove-amdefine
define during build#202zertosh wants to merge 1 commit intomozilla:masterfrom
zertosh:remove-amdefine
Conversation
Contributor
Author
|
For a better diff w/o the whitespace changes: https://github.com/mozilla/source-map/pull/202/files?w=1 |
Contributor
|
I haven't overlooked or forgotten this PR, I just need to malloc a larger block of time to really start digging in. |
Contributor
|
Doing #205 instead, which avoids the blame game but should still satisfy all your needs. |
Contributor
Author
|
Awesome! Thanks! Very clever solution to the indentation problem 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158, #179, #140 and #67.
This PR removes "amdefine" in favor of wrapping the modules in AMD wrappers during build time. This makes "source-map" friendlier to node and browserify/webpack environments – while still providing the AMDness needed for the FF devtools (I think that's why it's there 1 2). This approach carries no maintenance overhead, and should be 100% compatible with existing uses.
The problem is that then I own the entire git blame. Any solutions? Maybe leave the indentation alone?
cc: @fitzgen