Improve serialization perf#203
Merged
fitzgen merged 2 commits intomozilla:masterfrom Aug 25, 2015
zertosh:node-bench
Merged
Conversation
Contributor
|
Looks great! Thanks! I'm just going to run the benchmarks locally, real quick. |
Contributor
|
Very nice :) |
fitzgen
added a commit
that referenced
this pull request
Aug 25, 2015
Improve source-map serialization performance. The "Serializing source map" benchmark time was cut in half. About half of those gains are from reducing the calls to util.toSetString in ArraySet, the other half is from removing the duplicate calls to indexOf.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Serializing source map" benchmark time was cut in half. About half of those gains are from reducing the calls to
util.toSetStringinArraySet, the other half is from removing the duplicate calls toindexOf.Before:
After: