This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Remove heavy users#435
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
=========================================
+ Coverage 69.62% 69.9% +0.28%
=========================================
Files 48 45 -3
Lines 4141 4007 -134
Branches 146 135 -11
=========================================
- Hits 2883 2801 -82
+ Misses 1258 1206 -52Continue to review full report at Codecov.
|
Contributor
|
I just hit "update branch". This should be able to pass tests again with #436 merged. |
mreid-moz
approved these changes
Jun 8, 2018
Contributor
mreid-moz
left a comment
mreid-moz
left a comment
There was a problem hiding this comment.
This looks good to me. It seems a shame to delete the partitioner code, but since it isn't used by anything else, I think it's the right call.
Contributor
Author
|
@mreid-moz they're in the git log, we can always dust 'em off if we want them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if you see something I missed.