Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Fix problem that caused CI on forks to fail#436

Merged
jklukas merged 1 commit into
mozilla:masterfrom
jklukas:fix-forks
Jun 7, 2018
Merged

Fix problem that caused CI on forks to fail#436
jklukas merged 1 commit into
mozilla:masterfrom
jklukas:fix-forks

Conversation

@jklukas
Copy link
Copy Markdown
Contributor

@jklukas jklukas commented Jun 6, 2018

We were trying to build an uberjar and stage in S3,
but that requires encrypted env vars that aren't avaialable to
builds on forks, so we need to make the assembly and deploy stages conditional.

@jklukas jklukas force-pushed the fix-forks branch 10 times, most recently from 627c9f6 to 14f0727 Compare June 7, 2018 11:17
We were trying to build an uberjar and stage in S3,
but that requires encrypted env vars that aren't avaialable to
builds on forks, so we'll have to sacrifice build time
a bit and move assembly to the same step as deploying the jar
to S3.
@jklukas jklukas requested a review from fbertsch June 7, 2018 12:08
@mozilla mozilla deleted a comment from codecov-io Jun 7, 2018
Copy link
Copy Markdown
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after successful branch build

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 7, 2018

Codecov Report

Merging #436 into master will decrease coverage by 51.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #436       +/-   ##
===========================================
- Coverage   69.62%   18.03%   -51.59%     
===========================================
  Files          48       48               
  Lines        4141     4141               
  Branches      146      146               
===========================================
- Hits         2883      747     -2136     
- Misses       1258     3394     +2136
Impacted Files Coverage Δ
...ozilla/telemetry/utils/ConsistentPartitioner.scala 0% <0%> (-100%) ⬇️
...n/scala/com/mozilla/telemetry/ml/AMODatabase.scala 0% <0%> (-100%) ⬇️
...m/mozilla/telemetry/utils/CustomPartitioners.scala 0% <0%> (-100%) ⬇️
...cala/com/mozilla/telemetry/utils/Aggregation.scala 0% <0%> (-92.31%) ⬇️
...n/scala/com/mozilla/telemetry/utils/MainPing.scala 5.18% <0%> (-90.16%) ⬇️
.../main/scala/com/mozilla/telemetry/utils/udfs.scala 0% <0%> (-89.19%) ⬇️
.../mozilla/telemetry/views/GenericLongitudinal.scala 0% <0%> (-86.85%) ⬇️
...m/mozilla/telemetry/experiments/Permutations.scala 0% <0%> (-85.72%) ⬇️
...m/mozilla/telemetry/utils/SyncPingConversion.scala 0% <0%> (-81.82%) ⬇️
...n/scala/com/mozilla/telemetry/avro/JSON2Avro.scala 0% <0%> (-80.96%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41b87f...985f42f. Read the comment docs.

@jklukas
Copy link
Copy Markdown
Contributor Author

jklukas commented Jun 7, 2018

https://travis-ci.org/mozilla/telemetry-batch-view/builds/389414524 was successful, so merging. The codecov report is erroneous, I believe, because one of the jobs died and had to be restarted, which confused the merging of reports.

@jklukas jklukas merged commit 31912c4 into mozilla:master Jun 7, 2018
@jklukas jklukas deleted the fix-forks branch June 7, 2018 20:43
@jklukas jklukas mentioned this pull request Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants