This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Fix problem that caused CI on forks to fail#436
Merged
Conversation
627c9f6 to
14f0727
Compare
We were trying to build an uberjar and stage in S3, but that requires encrypted env vars that aren't avaialable to builds on forks, so we'll have to sacrifice build time a bit and move assembly to the same step as deploying the jar to S3.
fbertsch
approved these changes
Jun 7, 2018
Contributor
fbertsch
left a comment
There was a problem hiding this comment.
LGTM after successful branch build
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
===========================================
- Coverage 69.62% 18.03% -51.59%
===========================================
Files 48 48
Lines 4141 4141
Branches 146 146
===========================================
- Hits 2883 747 -2136
- Misses 1258 3394 +2136
Continue to review full report at Codecov.
|
Contributor
Author
|
https://travis-ci.org/mozilla/telemetry-batch-view/builds/389414524 was successful, so merging. The codecov report is erroneous, I believe, because one of the jobs died and had to be restarted, which confused the merging of reports. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were trying to build an uberjar and stage in S3,
but that requires encrypted env vars that aren't avaialable to
builds on forks, so we need to make the assembly and deploy stages conditional.