GTFS-RT > TimeZone issue for late/early text issue

[mmathieum]

The time is right but the early/late diff in minute is X hours too much

Seen with https://github.com/mtransitapps/fr-perpignan-sankeo-bus-android in ET. (6 hours = 360 minutes timezone diff)

Can reproduce on latest Store releases but not on latest master debug builds. 🤔

[mmathieum]

Seen with https://github.com/mtransitapps/ca-calgary-transit-bus-android in Prod as well.

[mmathieum]

Happened again with ca-edmonton-ets-bus-android as well.
Could only reproduce in release build type for a while and then it disappear before finding the root of the issue 🤔

[mmathieum]

Found the bug!

Agency time zone ID was right only the 1st time because the TimeZone.getDefault().id was always cached instead of the agency time zone 🤯

commons-android/src/main/java/org/mtransit/android/commons/provider/agency/AgencyUtils.kt

Lines 37 to 42 in 2fe1ec4

	@JvmStatic
	fun getRDSAgencyTimeZoneId(context: Context): String =
	_timeZone ?: context.getString(R.string.gtfs_rts_timezone) // do not change to avoid breaking compat w/ old modules
	.takeIf { it.isNotBlank() }
	?: TimeZone.getDefault().id // TODO support for bike_station
	.also { _timeZone = it }

-> so it only affect users checking out GTFS-RT data for transit agencies in different time-zone than their device