GTFS-RT > fix time-zone issue...

[mmathieum]

Agency time zone ID was right only the 1st time because the TimeZone.getDefault().id was always cached instead of the agency time zone 🤯

• GTFS-RT > TimeZone issue for late/early text issue #123

[gemini-code-assist]

Code Review

This pull request refactors logging and time zone handling across several GTFS-related components. Key changes include updating makeRequest to accept a specific loggable object for better logging context, incorporating bike station time zones in AgencyUtils, and enhancing the string representation of GTFS real-time data with duration and date-time formatting. Additionally, several local variables were marked as final in Java files, and debug logging was improved to use a centralized Constants.DEBUG flag. I have no feedback to provide.

[Copilot]

Pull request overview

Fixes a GTFS-RT time zone selection/caching bug that caused “early/late” minute differences to be offset by the device time zone, by ensuring the agency time zone is resolved correctly (and consistently) across providers and logs.

Changes:

• Add a new agency resource key (poi_agency_timezone) and update AgencyUtils to resolve the agency time zone via prioritized resource lookup.
• Update GTFS-RT request building to accept an explicit MTLog.Loggable for consistent logging across call sites.
• Improve GTFS-RT debug/log formatting (delay as duration, additional timestamp fields, extra trace logging).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/main/res/values/poi_agency_values.xml	Adds poi_agency_timezone placeholder for module-generated agency configuration.
src/main/java/org/mtransit/android/commons/provider/vehiclelocations/GTFSRealTimeVehiclePositionsProvider.kt	Passes loggable into makeRequest() for consistent logging.
src/main/java/org/mtransit/android/commons/provider/status/GTFSRealTimeTripUpdatesProvider.kt	Passes loggable into makeRequest() and adds a new info log on parsed trip updates.
src/main/java/org/mtransit/android/commons/provider/gtfs/GtfsRealtimeExt.kt	Enhances GTFS-RT object string formatting and adds scheduled time helpers.
src/main/java/org/mtransit/android/commons/provider/gtfs/GTFSStatusProvider.java	Uses the agency time zone ID from AgencyUtils when initializing date/time formatters and calendars.
src/main/java/org/mtransit/android/commons/provider/gtfs/GTFSRealTimeProviderExt.kt	Extends makeRequest() signature with loggable and routes logs through it.
src/main/java/org/mtransit/android/commons/provider/agency/AgencyUtils.kt	Fixes time zone resolution by using prioritized resource lookup and avoiding caching the agency time zone ID.
src/main/java/org/mtransit/android/commons/provider/GTFSRealTimeProvider.java	Updates Java call site for new makeRequest() signature.
src/main/java/org/mtransit/android/commons/data/ScheduleExt.kt	Adds time zone ID to Schedule.Timestamp short string for debugging.
src/main/java/org/mtransit/android/commons/data/Schedule.java	Minor refactors (final locals / simplified null check) in JSON parsing.
src/main/java/org/mtransit/android/commons/MTLog.java	Uses Constants.DEBUG for makeTime() formatting decision.
src/main/java/org/mtransit/android/MtLogExt.kt	Adjusts toDateTimeLog() formatting based on Constants.DEBUG.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors timezone handling and logging across several providers. Key changes include updating AgencyUtils to support a new poi_agency_timezone resource, improving logging context by passing Loggable objects to network requests, and enhancing GTFS-Realtime data formatting. Feedback was provided regarding the static caching of date formatters in GTFSStatusProvider, which could lead to incorrect timezone usage if the process is reused for different agencies or if the timezone changes.