[internal] Add explicit type annotations to components#1456
Closed
michaldudak wants to merge 4 commits intomui:masterfrom
Closed
[internal] Add explicit type annotations to components#1456michaldudak wants to merge 4 commits intomui:masterfrom
michaldudak wants to merge 4 commits intomui:masterfrom
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
atomiks
approved these changes
Feb 21, 2025
github-actions
bot
added
the
PR: out-of-date
Member
Author
|
This is no longer necessary after we removed prop-types. |
oliviertassinari
added
internal
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #705.
New components had the same issue. I added a test to prevent it from happening again.