[internal] Add explicit type annotations to components#705
Merged
michaldudak merged 4 commits intomui:masterfrom Oct 10, 2024
Merged
[internal] Add explicit type annotations to components#705michaldudak merged 4 commits intomui:masterfrom
michaldudak merged 4 commits intomui:masterfrom
Conversation
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
atomiks
approved these changes
Oct 9, 2024
Contributor
atomiks
left a comment
atomiks
left a comment
There was a problem hiding this comment.
Isn't typing props directly now redundant since it's typed with React.FC now?
Member
Author
|
Yup, I just removed them. |
oliviertassinari
added
internal
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Components defined as functions (i.e. without
forwardRef) with added propTypes ends up having an unexpected type in resulting .d.ts (as described in #651). This also causes #622.Adding an explicit type annotation solves both of these problems.
Closes #622
Closes #651