Conversation
41f5e27 to
31b41f5
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
31b41f5 to
87b0a6a
Compare
docs/src/icons/LinkIcon.tsx
Outdated
| @@ -0,0 +1,16 @@ | |||
| import * as React from 'react'; | |||
|
|
|||
| export function LinkIcon(props: React.ComponentProps<'svg'>) { | |||
There was a problem hiding this comment.
@colmtuite I just used a material icon here, maybe you have a better one? (not sure where the existing ones are from)
|
Think the icon should be revealed on focus as well |
|
This comment was marked as outdated.
This comment was marked as outdated.
Updated! @colmtuite |
|
@mj12albert We need responsive scroll-margin-top now, because the mobile header is 48px, but scroll-margin is just 24px. So gotta set it for mobile-first, then tweak it back to 24px for larger screens. |
There was a problem hiding this comment.
In the execution, could we also bring this from Material UI mui/material-ui#41994? I frequently select the header text and using a <a> break this flow.
|
@oliviertassinari Wouldn't that break native functionality of dragging an |
@colmtuite It does (I never use this). If we can only have the ability to double-click to select the whole text, it would help, but I have a workaround (selecting text, starting outside of the element, so it's kind of ok).
I think the use case is maintainer-related, not about end-users. I usually use this to leave comments on the heading structure, propose changes. |
|
Updated scroll-margin-top: https://deploy-preview-1795--base-ui.netlify.app/react/components/checkbox#api-reference @colmtuite |
|
@mj12albert On mobile now when I click a heading, it's touching the header/appbar. |
@colmtuite Fixed: https://deploy-preview-1795--base-ui.netlify.app/react/components/checkbox#api-reference |

Example: https://deploy-preview-1795--base-ui.netlify.app/react/components/checkbox#api-reference
Closes #1181