[docs-infra] Prevent link anchor when selecting text#41994
Merged
alexfauquette merged 6 commits intomui:nextfrom Jun 6, 2024
Merged
[docs-infra] Prevent link anchor when selecting text#41994alexfauquette merged 6 commits intomui:nextfrom
alexfauquette merged 6 commits intomui:nextfrom
Conversation
alexfauquette
added
the
scope: docs-infra
Netlify deploy previewhttps://deploy-preview-41994--material-ui.netlify.app/ Bundle size report |
alexfauquette
force-pushed
the
experiement-link
branch
from
b40c3fe to
7c8de6b
Compare
alexfauquette
changed the title
alexfauquette
commented
Jun 5, 2024
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
bharatkashyap
approved these changes
Jun 6, 2024
alexfauquette
changed the title
aarongarciah
reviewed
Jun 7, 2024
| codeOpen: PropTypes.bool.isRequired, | ||
| codeVariant: PropTypes.string.isRequired, | ||
| copyButtonOnClick: PropTypes.object.isRequired, | ||
| copyButtonOnClick: PropTypes.func.isRequired, |
Member
There was a problem hiding this comment.
Nice! I was about to open a PR to fix this prop type 👏
Member
Author
There was a problem hiding this comment.
Some time I open my dev tools and spot warning errors 😁
1 task
Member
|
Cool, the UX looks as good as it could be ✨ I noticed a couple of ways we can improve this: #42593. |
oliviertassinari
added
type: bug
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #39350, solving #39603 (review)
The prevent default is weird, because if we use the
documents.addEventlistnerto triggerevent.preventDefault()the link is still working 🙈Did not found the why, so I just moved to the simplest approach: loop over links and add the event listener.
Screencast.from.16-05-2024.11.37.07.mp4