[test] Set the URL to better match real environments#34449
Merged
oliviertassinari merged 2 commits intomui:masterfrom Sep 26, 2022
Merged
[test] Set the URL to better match real environments#34449oliviertassinari merged 2 commits intomui:masterfrom
oliviertassinari merged 2 commits intomui:masterfrom
Conversation
4 tasks
Member
|
I added it because of the error I got in jsdom/jsdom#2383 when I was writing tests for Happy to remove it if it does not produce the error anymore. |
siriwatknp
approved these changes
Sep 26, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Member
Author
|
@siriwatknp Thanks for the context, so I assume that #34027 solved the issue hence the comment that points to jsdom/jsdom#2383 is misleading, it's a case that we need to support 😁. Now, in hindsight, it's because you have added the URL that we could surface a bug in the tests of MUI X, which lead to mui/mui-x#6273. I think that it does make more sense to have the URL equal |
oliviertassinari
changed the title
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic was added in #31273. I'm testing that we no longer need it. I suspect that it was added to solve #33853. Removing it makes the test environment better capture the complexity of the production environments, it can also be seen as a test for #34027.