Skip to content

[Joy] Add Checkbox component#31273

Merged
siriwatknp merged 15 commits intomui:masterfrom
siriwatknp:joy/checkbox1
Mar 7, 2022
Merged

[Joy] Add Checkbox component#31273
siriwatknp merged 15 commits intomui:masterfrom
siriwatknp:joy/checkbox1

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 2, 2022

🖥 Preview

🎠 Variables Playground


A simple checkbox that leverages useSwitch from MUI Base and has APIs similar to @mui/material.


@siriwatknp siriwatknp added the package: joy-ui Specific to Joy UI. label Mar 2, 2022
@mui-bot
Copy link

mui-bot commented Mar 2, 2022

Details of bundle changes

@mui/joy: parsed: +3.40% , gzip: +2.63%

Generated by 🚫 dangerJS against 1da9f6d

@siriwatknp siriwatknp requested a review from hbjORbj March 2, 2022 14:05
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 3, 2022
Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not important, but some components in the demo are slightly misaligned.

@hbjORbj hbjORbj added scope: checkbox Changes related to the checkbox. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Mar 3, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 3, 2022
@hbjORbj
Copy link
Contributor

hbjORbj commented Mar 3, 2022

Hey, Jun, I pushed a commit where I added iconSize (consisting of values from xs to xl) to theme.vars and then used it in your Checkbox component.

I pushed it to minimise our merge conflicts in the future because I need this theme variable for Avatar component, which I am currently working on, as well. I hope you don't mind!

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 4, 2022
@hbjORbj hbjORbj mentioned this pull request Mar 4, 2022
1 task
@siriwatknp siriwatknp requested a review from hbjORbj March 7, 2022 03:42
Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: joy-ui Specific to Joy UI. scope: checkbox Changes related to the checkbox.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants