Conversation
hbjORbj
added
scope: avatar
| /** | ||
| * Private module reserved for @mui packages. | ||
| */ | ||
| export default function createSvgIcon(path: React.ReactNode, displayName: string): typeof SvgIcon { |
There was a problem hiding this comment.
@siriwatknp Copied from your checkbox MR (#31273)
|
@mui/joy: parsed: +2.20% , gzip: +1.95% |
| * @default 'md' | ||
| */ | ||
| size: PropTypes /* @typescript-to-proptypes-ignore */.oneOfType([ | ||
| PropTypes.oneOf(['lg', 'md', 'sm']), |
There was a problem hiding this comment.
it looks nice shortening the size props. It would be nice too if we keep the consistency of size props like the other component?
wdyt @hbjORbj @DanailH @siriwatknp
There was a problem hiding this comment.
@pahrizal Glad, you like it! this component is for the new design system (Joy UI) we are working on but the image you posted is Material UI, so right now it is a different package. We will try to make both of them consistent to yield the best DX in the future.
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
Looks good overall but I am not sure about the shape prop because of #29962 (comment). cc @danilo-leal
Makes sense. We already provide |
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Looking great so far!
5 participants
I have followed (at least) the PR section of the contributing guide.
variant:'outlined' | 'light' | 'contained'(containedby default)color:'danger' | 'info' | 'neutral' | 'primary' | 'success' | 'warning'(neutralby default)size:'sm' | 'md' | 'lg'(mdby default)Preview: https://deploy-preview-31303--material-ui.netlify.app/experiments/joy/avatar/