[website] Clean up the GetStartedButtons component#38256
Merged
danilo-leal merged 12 commits intomasterfrom Aug 8, 2023
Merged
[website] Clean up the GetStartedButtons component#38256danilo-leal merged 12 commits intomasterfrom
GetStartedButtons component#38256danilo-leal merged 12 commits intomasterfrom
Conversation
danilo-leal
added
the
website
1 task
Netlify deploy previewhttps://deploy-preview-38256--material-ui.netlify.app/ Bundle size report |
danilo-leal
commented
Aug 3, 2023
github-actions
bot
added
the
PR: out-of-date
…d-button-improvement
…d-button-improvement
github-actions
bot
removed
the
PR: out-of-date
Collaborator
Author
|
@siriwatknp & @bharatkashyap would appreciate a double-check on this one! 😬 Would love to merge it this week. |
bharatkashyap
approved these changes
Aug 8, 2023
Collaborator
bharatkashyap
left a comment
bharatkashyap
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for this effort 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes on this PR
GetStartedButtons2created while developing the Base UI page.GetStartedButtonthrough thealtInstallationprop.user-select: nonefrom theNpmCopyButtonas per this feedback: [website] Add Base UI marketing page #36622 (comment)Not 100% sure if the tweaked prop names are the best (I liked the simpler
toandcallToActionbetter!) 😬I'm open to suggestions here if there are better options!
https://deploy-preview-38256--material-ui.netlify.app/base-ui