[website] Make get started buttons reusable#38283
Closed
bharatkashyap wants to merge 1 commit intomui:masterfrom
Closed
[website] Make get started buttons reusable#38283bharatkashyap wants to merge 1 commit intomui:masterfrom
bharatkashyap wants to merge 1 commit intomui:masterfrom
Conversation
bharatkashyap
added
the
website
danilo-leal
reviewed
Aug 2, 2023
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Ah, sweet! I opened basically the same PR a few days ago: #38256 😬
How about concentrating efforts there? I'm basically removing the GetStartedButton2 component and increasing the capacity on the original GetStartedButton!
Netlify deploy previewhttps://deploy-preview-38283--material-ui.netlify.app/ Bundle size report |
Collaborator
Author
Ah, thanks! Let's do that 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intend to reuse the
GetStartedButtons2component on the Toolpad landing page, so I've added some changes to allow reuse.