Skip to content

[docs][dialog] Fix key warning in SimpleDialog demo#38580

Merged
ZeeshanTamboli merged 1 commit intomui:masterfrom
ZeeshanTamboli:docs-dialog-key-warning
Aug 22, 2023
Merged

[docs][dialog] Fix key warning in SimpleDialog demo#38580
ZeeshanTamboli merged 1 commit intomui:masterfrom
ZeeshanTamboli:docs-dialog-key-warning

Conversation

@ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 21, 2023

Noticed while running the docs locally. A regression introduced in #33970.

@ZeeshanTamboli ZeeshanTamboli added type: bug It doesn't behave as expected. docs Improvements or additions to the documentation. scope: dialog Changes related to the dialog. package: material-ui labels Aug 21, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Fix key warning in console for SimpleDialog demo [docs][material-ui] Fix key warning for SimpleDialog demo Aug 21, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Fix key warning for SimpleDialog demo [docs][material-ui] Fix key warning in SimpleDialog demo Aug 21, 2023
@mui-bot
Copy link

mui-bot commented Aug 21, 2023

Netlify deploy preview

https://deploy-preview-38580--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4d4f848

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 21, 2023 16:56
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ZeeshanTamboli ZeeshanTamboli merged commit d673fa8 into mui:master Aug 22, 2023
@ZeeshanTamboli ZeeshanTamboli deleted the docs-dialog-key-warning branch August 22, 2023 04:40
@oliviertassinari oliviertassinari added the type: regression A bug, but worse, it used to behave as expected. label Nov 20, 2024
@oliviertassinari oliviertassinari changed the title [docs][material-ui] Fix key warning in SimpleDialog demo [docs][dialog] Fix key warning in SimpleDialog demo Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: dialog Changes related to the dialog. type: bug It doesn't behave as expected. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants