[docs][dialog] Fix padding in SimpleDialog demo#44467
Merged
aarongarciah merged 1 commit intomui:masterfrom Nov 25, 2024
Merged
[docs][dialog] Fix padding in SimpleDialog demo#44467aarongarciah merged 1 commit intomui:masterfrom
aarongarciah merged 1 commit intomui:masterfrom
Conversation
oliviertassinari
added
type: bug
Netlify deploy previewhttps://deploy-preview-44467--material-ui.netlify.app/ Bundle size report |
oliviertassinari
changed the title
oliviertassinari
changed the title
aarongarciah
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this by chance, it has been broken for a long time, broken in #33970 (the second regression of the PR, the first one was #38580), and it looked quick to fix, so I was compelled to go after it.
Was correct https://v5-0-6.mui.com/components/dialogs/
Before: https://mui.com/material-ui/react-dialog/#introduction
After: https://deploy-preview-44467--material-ui.netlify.app/material-ui/react-dialog/
For context, this demo is modeled after https://m1.material.io/components/dialogs.html#dialogs-simple-dialogs.