[docs-infra] Fix hydration api#39706
Merged
oliviertassinari merged 1 commit intomui:masterfrom Nov 12, 2023
Merged
Conversation
oliviertassinari
added
type: bug
Netlify deploy previewhttps://deploy-preview-39706--material-ui.netlify.app/ Bundle size report |
Comment on lines
+227
to
+233
| {disableAd ? null : ( | ||
| <BrandingProvider> | ||
| <AdGuest> | ||
| <Ad /> | ||
| </AdGuest> | ||
| </BrandingProvider> | ||
| )} |
Member
There was a problem hiding this comment.
Since the two other <Ad /> are used with the same wrapper. Would it make sens to rename Ad by AddContent
And define <Ad /> as follow:
const Ad = ({ disableAd }) => {
if (disableAd) {
return null;
}
return <BrandingProvider>
<AdGuest>
<AddContent />
</AdGuest>
</BrandingProvider>
}
Member
Author
There was a problem hiding this comment.
We could bundle <AdGuest> and <Ad> together, it makes sense.
I wouldn't bundle <BrandingProvider> because this one shouldn't be here. I think we nest way too many ThemeProviders in our docs, I suspect part of why pages are this slow. I think that one theme provider higher in the tree for the docs itself, and one theme provider per demo is enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed this while I was looking at #39704.
Before http://0.0.0.0:3000/material-ui/api/dialog/
After: no more hydration warning. https://deploy-preview-39706--material-ui.netlify.app/material-ui/api/dialog/
A continuation of #35201.