[docs–infra] Small polish on API toggle#39704
Merged
alexfauquette merged 2 commits intomui:masterfrom Nov 2, 2023
Merged
Conversation
oliviertassinari
added
the
scope: docs-infra
Netlify deploy previewhttps://deploy-preview-39704--material-ui.netlify.app/ Bundle size report |
This was referenced Nov 2, 2023
oliviertassinari
added
the
type: enhancement
This was referenced Nov 2, 2023
oliviertassinari
added a commit
that referenced
this pull request
Nov 3, 2023
This reverts commit b30069d.
oliviertassinari
commented
Jan 1, 2024
Comment on lines
-82
to
-91
| setNeedsScroll(false); | ||
| if (needsScroll) { | ||
| return () => { | ||
| const id = document?.location.hash.slice(1); | ||
| const element = document.getElementById(id); | ||
| element?.scrollIntoView(); | ||
| }; | ||
| if (option !== DEFAULT_LAYOUT) { | ||
| const id = document.location.hash.slice(1); | ||
| const element = document.getElementById(id); | ||
| element?.scrollIntoView(); | ||
| } | ||
| return () => {}; | ||
| }, [needsScroll]); |
Member
Author
There was a problem hiding this comment.
I shouldn't have changed this, introducing the logic back in #40395. It led to a bug, the scroll override after first render (the effect re-run).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick follow-up on #39490.
My main concern was about the double render, I didn't benchmark it, but I would expect it not to help with the performance of the page.
Preview: https://deploy-preview-39704--material-ui.netlify.app/material-ui/api/autocomplete/#Autocomplete-prop-renderInput