[docs-infra] Fix scroll position with anchor links#40395
Closed
oliviertassinari wants to merge 1 commit intomui:masterfrom
Closed
[docs-infra] Fix scroll position with anchor links#40395oliviertassinari wants to merge 1 commit intomui:masterfrom
oliviertassinari wants to merge 1 commit intomui:masterfrom
Conversation
oliviertassinari
added
type: bug
Netlify deploy previewhttps://deploy-preview-40395--material-ui.netlify.app/ Bundle size report |
oliviertassinari
requested review from
alexfauquette
and removed request for
a team
Member
|
Not sure about what you're fixing. Is it the scroll not stopping at the correct position? What I had in mind is easier. The CSS classes have wrong anchors:
links.mp4 |
Member
Author
|
@alexfauquette The problem I saw is the scroll position that is wrong. So indeed, I was off-topic. I'm fixing this in #40450 then. It's quick. For the URLs, I would lean as much as possible on the kebab case, but maybe for the end of the hash, class name, prop name, matching the exact same case is better. |
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: https://mui.com/base-ui/react-slider/components-api/#Slider-classes-active
You can see the two bugs at once on this recording. First the scroll get messed up when I change the display type. Second the scroll restoration is wrong when I load the page.
Screen.Recording.2024-01-05.at.23.19.57.mov
After: https://deploy-preview-40395--material-ui.netlify.app/base-ui/react-slider/components-api/#Slider-classes-active