[docs-infra] Render footer in SSR#39710
Merged
oliviertassinari merged 1 commit intomui:masterfrom Nov 2, 2023
Merged
Conversation
oliviertassinari
added
type: bug
Netlify deploy previewhttps://deploy-preview-39710--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
footer-ssr
branch
from
3db0e2a to
bd5d8f3
Compare
danilo-leal
approved these changes
Nov 2, 2023
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Much better — thanks for tackling it! I had noticed this, too, but didn't know how to fix it. 🤙
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed this while I was looking at #39704.
<div>. BeforeScreen.Recording.2023-11-02.at.02.02.04.mov
Preview: https://deploy-preview-39710--material-ui.netlify.app/material-ui/getting-started/design-resources/