Skip to content

[material-ui][Badge] Deprecate components and componentProps props for v6#41364

Closed
skmanoj322 wants to merge 12 commits intomui:masterfrom
skmanoj322:manoj/badge-v6-deprecations
Closed

[material-ui][Badge] Deprecate components and componentProps props for v6#41364
skmanoj322 wants to merge 12 commits intomui:masterfrom
skmanoj322:manoj/badge-v6-deprecations

Conversation

@skmanoj322
Copy link
Copy Markdown
Contributor

part of #41279

@DiegoAndai I have reffered to Slider please tell if there is any correction to be made.

looking forward to this pr to merge as this is my first pr in open source.

@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 5, 2024

@zannager zannager added the scope: badge Changes related to the badge. label Mar 5, 2024
@zannager zannager requested a review from DiegoAndai March 5, 2024 15:20
@skmanoj322 skmanoj322 closed this Mar 7, 2024
@skmanoj322 skmanoj322 deleted the manoj/badge-v6-deprecations branch March 7, 2024 15:08
@DiegoAndai
Copy link
Copy Markdown
Member

Hey @skmanoj322, sorry for the late reply. I was about to review this. Was there a particular reason you closed it?

@skmanoj322
Copy link
Copy Markdown
Contributor Author

skmanoj322 commented Mar 7, 2024

I think I have deleted that from my forked branch. sorry for trouble I will create on more pr

@skmanoj322 skmanoj322 restored the manoj/badge-v6-deprecations branch March 7, 2024 18:22
@skmanoj322
Copy link
Copy Markdown
Contributor Author

#41399 is the new pr. again sorry for the errors

@DiegoAndai
Copy link
Copy Markdown
Member

@skmanoj322 no problem! I'll review the new one.

@skmanoj322
Copy link
Copy Markdown
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: badge Changes related to the badge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants