[material-ui][Badge] Deprecated components and componentsProps props for v6 by skmanoj322 · Pull Request #41399 · mui/material-ui

skmanoj322 · 2024-03-07T18:26:20Z

@DiegoAndai part of #41279

I have followed (at least) the PR section of the contributing guide.

…j/badge-v6-deprecations

mui-bot · 2024-03-07T18:29:05Z

Netlify deploy preview

docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md

Bundle size report

Bundle size will be reported once CircleCI build #674699 finishes.

Generated by 🚫 dangerJS against 0583e74

DiegoAndai

Sorry for the delay in the review.

Let me know if you need help with any of these 😊

DiegoAndai · 2024-03-07T18:46:52Z

packages/mui-material/src/Badge/Badge.test.js

    });
  });

-  describe('prop: components / slots', () => {


No need to delete this, we will delete it when the prop is removed.

DiegoAndai · 2024-03-07T18:46:57Z

packages/mui-material/src/Badge/Badge.test.js

    });
  });

-  describe('prop: componentsProps / slotProps', () => {


No need to delete this, we will delete it when the prop is removed.

DiegoAndai · 2024-03-07T18:48:27Z

packages/mui-codemod/src/deprecations/badge-props/badge-props.test.js

We should also add the theme tests, like this one: https://github.com/mui/material-ui/blob/master/packages/mui-codemod/src/deprecations/slider-props/slider-props.test.js#L29

packages/mui-codemod/src/deprecations/badge-props/test-cases/excepted.js

DiegoAndai · 2024-03-07T18:51:27Z

packages/mui-codemod/src/deprecations/badge-props/test-cases/theme.expected.js

+
+      slotProps: {
+        root: slotsRootProps,
+        badge: slotsbadgeProps,


We need to update this one as well. Same as my previous comment (#41399 (comment)).

merged #41323

skmanoj322 · 2024-03-12T14:02:04Z

@DiegoAndai made changes as told by you. please review and give feedback

DiegoAndai

Hey @skmanoj322! Thanks for working on this. Here are some review comments:

packages/mui-codemod/src/deprecations/badge-props/test-cases/actual.js

packages/mui-codemod/src/deprecations/badge-props/test-cases/expected.js

skmanoj322 · 2024-03-13T14:29:53Z

Hey @DiegoAndai Thank you for bearing with me . I have refered the slider and alert component and implemented the same here. just a short question is there any particular logic to write these test (actual.js)

and ,pnpm tc <codemod> i tried to implement the command from the root terminal it gave me error.
can you give example how to implement these command?

DiegoAndai

Hey @skmanoj322!

To fix the failing test cases:

Running pnpm prettier should modify the files with errors, and then commit and push the changes
I left code suggestions to fix the codemod test failures

just a short question is there any particular logic to write these test (actual.js)

The idea is to cover all ways users might be using the deprecated props. Then you should be able to run

node packages/mui-codemod/codemod deprecations/badge-props packages/mui-codemod/src/deprecations/badge-props/test-cases/actual.js

And that would modify actual.js, then you copy the modified code to expected.js and undo the modification of actual.js

pnpm tc i tried to implement the command from the root terminal it gave me error

Did you run this?:

pnpm tc badge-props

What error did it throw?

DiegoAndai · 2024-03-13T18:26:04Z

packages/mui-codemod/src/deprecations/badge-props/badge-props.test.js

+      it('should be idempotent', () => {
+        const actual = transform({ source: read('./test-cases/actual.js') }, { jscodeshift }, {});
+
+        const excepted = read('./test-cases/excepted.js');


Suggested change

const excepted = read('./test-cases/excepted.js');

const excepted = read('./test-cases/expected.js');

DiegoAndai · 2024-03-13T18:26:14Z

packages/mui-codemod/src/deprecations/badge-props/badge-props.test.js

+      it('transforms props as needed', () => {
+        const actual = transform({ source: read('./test-cases/actual.js') }, { jscodeshift }, {});
+
+        const expected = read('./test-cases/excepted.js');


Suggested change

const expected = read('./test-cases/excepted.js');

const expected = read('./test-cases/expected.js');

DiegoAndai · 2024-03-13T18:28:08Z

packages/mui-codemod/src/deprecations/badge-props/badge-props.test.js

+  describe('deprecations', () => {
+    describe('badge-props', () => {
+      it('transforms props as needed', () => {
+        const actual = transform({ source: read('./test-cases/actual.js') }, { jscodeshift }, {});


Suggested change

const actual = transform({ source: read('./test-cases/actual.js') }, { jscodeshift }, {});

const actual = transform({ source: read('./test-cases/actual.js') }, { jscodeshift }, { printOptions: { trailingComma: true } });

these is missing in slider any specific reason why?

skmanoj322 · 2024-03-14T17:31:25Z

hey @DiegoAndai tried to run these test

What error did it throw?

pnpm tc badge-props

and for

pnpm eslint. i think these will clear my ci/circleci: test_static

btw really appricate your mentoring thanks for the guidence 🎉 👍

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

merging master

skmanoj322 · 2024-03-25T14:07:47Z

@DiegoAndai sorry i think there is a lot to merge conflit i have to resolve that . again sorry for trouble again 😞 .

i thing there is lot of code changes that have happened . shall i just create new PR?

Or
is it right way

We will have to update this after #41323 was merged. For this, we need to merge master into this branch:

git checkout master

git pull upstream master

git checkout manoj/badge-v6-deprecations

git merge master

Run the codemod on the actual.js file and copy it here

Let me know if you need help 😊

This reverts commit 4a9e8c2.

This reverts commit 1f419af.

This reverts commit 71992c1.

This reverts commit 168604e, reversing changes made to ddcf911.

DiegoAndai · 2024-03-26T17:29:13Z

Closing in favor of #41655

DiegoAndai · 2024-03-26T17:31:35Z

@skmanoj322 sorry I was late in replying to this PR. The issue that caused so many files to change is that we recently switched to the next branch, so in this instructions:

git checkout master

git pull upstream master

git checkout manoj/badge-v6-deprecations

git merge master

Run the codemod on the actual.js file and copy it here

Instad of master, we should've merged next. But the other PR is approved now 👍🏼

skmanoj322 added 12 commits February 20, 2024 17:12

badge.json

4a29139

badge test where added

d3cee36

modified - badge folder

d0fc9ab

codemod update

a637de5

codemod changes

e2c5f06

minnor changes

763a2d9

final-commit-1115

f816919

codemod-changes

1959307

badge correction

06ece7a

adjusted codemon code

c7d9c3e

Merge branch 'master' of https://github.com/mui/material-ui into mano…

d3cb8d2

…j/badge-v6-deprecations

removed autocomplete from md

d36a63a

skmanoj322 mentioned this pull request Mar 7, 2024

[material-ui][Badge] Deprecate components and componentProps props for v6 #41364

Closed

1 task

DiegoAndai reviewed Mar 7, 2024

View reviewed changes

zannager added the scope: badge Changes related to the badge. label Mar 8, 2024

skmanoj322 added 5 commits March 12, 2024 18:04

Merge branch 'master' into manoj/badge-v6-deprecations

9a7e6b8

merged #41323

added theme test

2526e56

updated expected.js

ddc381f

restored the test cases

1b85030

updated theme.expected.js

44c33b1

DiegoAndai mentioned this pull request Mar 12, 2024

[material-ui] Deprecate components and componentsProps props #41279

Closed

17 tasks

DiegoAndai reviewed Mar 12, 2024

View reviewed changes

skmanoj322 added 2 commits March 13, 2024 19:26

modified actual.js

5525e7f

modified expected.js

f025c7f

DiegoAndai reviewed Mar 13, 2024

View reviewed changes

skmanoj322 added 2 commits March 14, 2024 09:07

modified readme

2e65e81

changed test file

ddcf911

skmanoj322 mentioned this pull request Mar 15, 2024

[codemod] Error while running command pnpm tc badge-props and pnpm eslint #41501

Closed

mnajdova changed the base branch from master to next March 19, 2024 09:32

[docs] Update the versions dropdown to show v6 (#41557)

c8dfeb0

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 20, 2024

danilo-leal and others added 8 commits March 20, 2024 22:39

[blog] Add post about remote (#41565)

deb7a6d

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

[docs] Add notification for MUI X v7 blog post (#41587) (#41605)

39fe215

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

[website] Update pricing table (#41606)

bd8ced4

Merge branch 'master' into manoj/badge-v6-deprecations

168604e

merging master

correct test cases

71992c1

ran pnpm docs:api

1f419af

updated readme codemod

4a9e8c2

skmanoj322 added 4 commits March 25, 2024 20:36

Revert "updated readme codemod"

1b9818b

This reverts commit 4a9e8c2.

Revert "ran pnpm docs:api"

ad0fbd7

This reverts commit 1f419af.

Revert "correct test cases"

0583e74

This reverts commit 71992c1.

Revert "Merge branch 'master' into manoj/badge-v6-deprecations"

c56b396

This reverts commit 168604e, reversing changes made to ddcf911.

DiegoAndai closed this Mar 26, 2024

skmanoj322 deleted the manoj/badge-v6-deprecations branch March 28, 2024 03:53

	const excepted = read('./test-cases/excepted.js');
	const excepted = read('./test-cases/expected.js');

	const expected = read('./test-cases/excepted.js');
	const expected = read('./test-cases/expected.js');

	const actual = transform({ source: read('./test-cases/actual.js') }, { jscodeshift }, {});
	const actual = transform({ source: read('./test-cases/actual.js') }, { jscodeshift }, { printOptions: { trailingComma: true } });

Uh oh!

Conversation

skmanoj322 commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

DiegoAndai left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DiegoAndai Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skmanoj322 commented Mar 12, 2024

Uh oh!

DiegoAndai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skmanoj322 commented Mar 13, 2024

Uh oh!

DiegoAndai left a comment

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

skmanoj322 Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

skmanoj322 commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skmanoj322 commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DiegoAndai commented Mar 26, 2024

Uh oh!

DiegoAndai commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

skmanoj322 commented Mar 7, 2024 •

edited

Loading

mui-bot commented Mar 7, 2024 •

edited

Loading

DiegoAndai left a comment •

edited

Loading

DiegoAndai Mar 7, 2024 •

edited

Loading

skmanoj322 commented Mar 14, 2024 •

edited

Loading

skmanoj322 commented Mar 25, 2024 •

edited

Loading