[internal] Update browser support versions#41568
Conversation
Netlify deploy preview@material-ui/core: parsed: -1.08% 😍, gzip: -1.35% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
|
There is also a "legacy" env in the babel config Line 16 in f6a89c1 |
|
Checking it again, I found several places related to IE11 to remove and I am afraid that this PR might be too big to review, so I will bring the |
.browserslistrc
Outdated
| opera 76 | ||
| safari 14 | ||
| samsung 13.0 | ||
| op_mob 73 # The op_mob 80 is unknown, so downgrading to 73 |
There was a problem hiding this comment.
It does work in Base UI: https://github.com/mui/base-ui/blob/master/.browserslistrc
Have you tried updating caniuse-lite to the latest version?
There was a problem hiding this comment.
@michaldudak It really because of caniuse-lite. However, I don't see any usage of "caniuse-lite" in any of the package.json, so I make it work with pnpm up "caniuse-lite". Is it the correct way to upgrade implicit deps? cc @Janpot
There was a problem hiding this comment.
Is it the correct way to upgrade implicit deps?
👍 Probably also want to run pnpm dedupe after. But I see no problem with this.
There was a problem hiding this comment.
@siriwatknp Actually, it seems to be
npx browserslist@latest --update-db
| safari 17.4 | ||
| safari 17.3 | ||
| safari 17.2 |
There was a problem hiding this comment.
We agreed upon Safari 15.4 for v6 at #40958 (comment)
There was a problem hiding this comment.
Thanks for pointing that out. Will update it. cc @michaldudak Would you like to use the same list for Base UI?
There was a problem hiding this comment.
We'll decide when it's closer to our release. Thanks for letting me know.
|
@siriwatknp Regarding node.js upgrade, have you seen the debates in mui/mui-x#10997 and #32546? |
Thanks, I will remove nodejs update from this PR. |
Janpot
left a comment
There was a problem hiding this comment.
Looks good. Last suggestion: If it makes sense, add a package.json script for updating the browserslist. And an instruction in the .browserslistrc file to run the script on major versions?
"update-browserslist": "browserslist@latest --update-db && browserslist@latest --mobile-to-desktop \"> 0.2%, last 2 versions, Firefox ESR, not dead\""
@Janpot I'm not sure if this is better. 🤔 |
|
Fair enough. Some release instructions makes sense as well. Maybe it makes sense to mention the |
Oh yes, that makes sense. I've done it manually by removing the lock entry and rerunning the install. 🙈 😆 |
DiegoAndai
left a comment
There was a problem hiding this comment.
Small fix on the documentation. Otherwise LGTM 👍🏼
docs/data/material/getting-started/supported-platforms/supported-platforms.md
Outdated
Show resolved
Hide resolved
Added a note to run |
…ui into browserslist-update
See #40958
npx browserslist --mobile-to-desktop "> 0.2%, last 2 versions, Firefox ESR, not dead"Removemove to the next PRlegacysince we no longer support IEnpx browserslist "maintained node versions"