[material-ui][Button] Convert to support CSS extraction#41378
[material-ui][Button] Convert to support CSS extraction#41378siriwatknp merged 26 commits intomui:nextfrom
Conversation
siriwatknp
added
scope: button
Netlify deploy previewhttps://deploy-preview-41378--material-ui.netlify.app/ @material-ui/core: parsed: +0.03% , gzip: +0.09% Bundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
|
Moved to v6 |
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
Had 2 small comments for the Button CSS extraction.
The styled changes make sense to me, although I might not have as much context as Brijesh or Marija.
Could these changes be split into separate PRs? One for the Button CSS extraction and another for the styled changes?
| props({ ownerState }) { | ||
| return ownerState.size === 'small'; | ||
| }, |
There was a problem hiding this comment.
| props({ ownerState }) { | |
| return ownerState.size === 'small'; | |
| }, | |
| props: { size: 'small' } |
Should work, right?
The same comment for the similar prop callbacks below
That makes sense. It can be split. |
| "@pigment-css/react": "workspace:^", | ||
| "@mui/utils": "workspace:^", | ||
| "@mui/base": "workspace:^", | ||
| "@mui/lab": "workspace:^", |
There was a problem hiding this comment.
The demo contains LoadingButton from @mui/lab
github-actions
bot
removed
the
PR: out-of-date
5 participants
Screen.Recording.2567-03-22.at.15.04.43.mov