[pigment-css] Fix props forwarding#41688
Conversation
…t/styled-forward-prop
…t/styled-forward-prop
| ); | ||
| const newProps = {}; | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| for (const key in props) { |
There was a problem hiding this comment.
I hope this is comparatively faster than Object.keys since optimizing this styled call is the most important part as it'll be called a lot.
There was a problem hiding this comment.
I think so, it's the same logic as emotion.
| loader: { | ||
| '.js': 'jsx', | ||
| }, |
There was a problem hiding this comment.
Added this after switching styled.jsx to styled.js to make the build work. I can't run the test with .jsx and there is no .jsx found the codebase.
Netlify deploy previewhttps://deploy-preview-41688--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
brijeshb42
left a comment
brijeshb42
left a comment
There was a problem hiding this comment.
All looks good. There is a bundle size increase significantly but it should be fine given the amount of functionality it is adding.
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
It's great to see this one handled 👌
4 participants
To unblock #41378
@emotion/is-prop-validshouldForwardPropfor root and other slots