[material-ui][FormControlLabel] Fix applying of slotprops#42303
Closed
[material-ui][FormControlLabel] Fix applying of slotprops#42303
Conversation
sai6855
changed the title
Netlify deploy previewhttps://deploy-preview-42303--material-ui.netlify.app/ Bundle size report |
sai6855
added
type: bug
Member
Author
|
I don't think argos change is related to this PR, reason being neither |
sai6855
commented
May 20, 2024
Comment on lines
+349
to
+351
| expect(getByTestId('typography')).to.have.style('white-space', 'nowrap'); | ||
| expect(getByTestId('typography')).to.have.style('overflow', 'hidden'); | ||
| expect(getByTestId('typography')).to.have.style('text-overflow', 'ellipsis'); |
Member
Author
There was a problem hiding this comment.
these are styles applied when noWrap is passed to typography
material-ui/packages/mui-material/src/Typography/Typography.js
Lines 81 to 86 in 9b2e523
Member
sai6855
force-pushed
the
fix-slotprops-formcontrollabel
branch
from
7ec4f67 to
eecb0a2
Compare
Member
Author
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #42277