[system][createStyled] Intercept ownerState coming from props and ownerState

[DiegoAndai]

From #42345 (comment)

This resolves the styled symptoms of #42184 by not allowing ownerState values coming from props or ownerState to override the component's ownerState.

It does not close #42184, as nested ownerState values are still being propagated.

[mui-bot]

Netlify deploy preview

https://deploy-preview-42358--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 30ec290

[DiegoAndai]

See Argos changes for the fixes

[mnajdova]

There are few more lines where we handle this, e.g.

material-ui/packages/mui-system/src/createStyled/createStyled.js

Line 51 in 65622f2

typeof callableStyle === 'function' ? callableStyle({ ownerState, ...props }) : callableStyle;

and

material-ui/packages/mui-system/src/createStyled/createStyled.js

Line 55 in 65622f2

processStyleArg(resolvedStyle, { ownerState, ...props }),

Can we create a const at the top of the function and used that in all places?

[DiegoAndai]

@mnajdova I refactored by creating a const and added a test.

For the occurrences you point out, there's no risk of overriding. The function signature is

function processStyleArg(callableStyle, { ownerState, ...props })

So props would never have an ownerState key. Because of this lines 51 and 55 won't show this issue, and we can leave them as is.

[mnajdova]

Test, logic and argos look good to me 👌 We should port this logic to Pigment CSS too.