[material-ui][Tab] Deprecate iconWrapper class for icon class#42647
Merged
DiegoAndai merged 6 commits intomui:nextfrom Jun 18, 2024
Merged
[material-ui][Tab] Deprecate iconWrapper class for icon class#42647DiegoAndai merged 6 commits intomui:nextfrom
DiegoAndai merged 6 commits intomui:nextfrom
Conversation
sai6855
added
scope: tabs
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
Merged
1 task
Member
|
@sai6855 @DiegoAndai a test is failing locally for me in latest 
|
Member
|
@sai6855 @DiegoAndai fix is up for review #42686 |
Comment on lines
+1483
to
+1484
| - .MuiTab-iconWrapper | ||
| + .MuiTab-icon |
Member
There was a problem hiding this comment.
Suggested change
| - .MuiTab-iconWrapper | |
| + .MuiTab-icon | |
| -.MuiTab-iconWrapper | |
| +.MuiTab-icon |
Moved to #42711
| - [`& .${tabClasses.iconWrapper}`]: { | ||
| + [`& .${tabClasses.icon}`]: { | ||
| color: 'red', | ||
| }, |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per this comment #42549 (comment), this PR deprecates
iconWrapperclass and foriconclass