[docs] Fix git diff format in migration to v6#42711
Merged
oliviertassinari merged 2 commits intomui:nextfrom Jun 23, 2024
Merged
[docs] Fix git diff format in migration to v6#42711oliviertassinari merged 2 commits intomui:nextfrom
oliviertassinari merged 2 commits intomui:nextfrom
Conversation
Netlify deploy previewBundle size report |
Comment on lines
-72
to
+73
| if (event.key === 'Escape' && chipRef.current) { | ||
| chipRef.current.blur(); | ||
| if (event.key === 'Escape') { | ||
| chipRef.current!.blur(); |
Member
Author
There was a problem hiding this comment.
I believe React guarantees the ref to be defined, so this is harmful defensive logic.
Comment on lines
103
to
+104
| <Grid | ||
| - disableEqualOverflow | ||
| - disableEqualOverflow |
Member
Author
There was a problem hiding this comment.
Code style (2 space tab)
Comment on lines
237
to
243
| ```diff | ||
| <Alert | ||
| - components={{ CloseButton: CustomButton }} | ||
| + slots={{ closeButton: CustomButton }} | ||
| - componentsProps={{ closeButton: { testid: 'test-id' } }} | ||
| + slots={{ closeButton: CustomButton }} | ||
| + slotProps={{ closeButton: { testid: 'test-id' } }} | ||
| /> |
Member
Author
There was a problem hiding this comment.
git diff groups deletion and addition to make them easier to read. I believe here it's simple enough that we should stick to the better default.
1 task
aarongarciah
approved these changes
Jun 23, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed those reading https://github.com/mui/material-ui/blob/next/packages/mui-codemod/README.md and https://next--material-ui.netlify.app/material-ui/migration/migration-v5/.